Skip to content

refactor: integrate GenLSP #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 3, 2025
Merged

refactor: integrate GenLSP #20

merged 16 commits into from
Jul 3, 2025

Conversation

mhanberg
Copy link
Member

@mhanberg mhanberg commented Jun 17, 2025 •
edited
Loading

Description

Integrate GenLSP server process.

Notes

  • Still working through this, but having trouble with a couple tests and a potential problem with namespacing, hoping @doorgan can help me through these last bits.
  • There are some extraneous changes in here that I'll revert before merging. Some credo rules, credo github package, etc
  • New GenLSP will get published to hex before merging.

mhanberg
mhanberg commented Jun 17, 2025
View reviewed changes
@mhanberg mhanberg marked this pull request as ready for review June 18, 2025 13:45
@doorgan doorgan mentioned this pull request Jun 18, 2025
Merged
Base automatically changed from doorgan/gen_lsp_datastructures to main June 18, 2025 16:07
@mhanberg mhanberg force-pushed the genlsp-server branch 2 times, most recently from 57a0dcd to 102ef34 Compare June 18, 2025 17:23
doorgan
doorgan reviewed Jun 23, 2025
View reviewed changes
@mhanberg
ci: remove nix action
7c9adb9 
Can deal with this later, it's currently just getting in my way
@mhanberg mhanberg requested a review from doorgan July 3, 2025 04:04
doorgan
doorgan approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works properly, the dialyzer CI has been quite annoying lately, but the changes here are solid

@mhanberg mhanberg merged commit bccb344 into main Jul 3, 2025
12 checks passed
@mhanberg mhanberg deleted the genlsp-server branch July 3, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doorgan doorgan doorgan approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhanberg @doorgan